Revert (#46438) [6.1] Fix TinyMCE editor not respecting width and height set#47325
Closed
brianteeman wants to merge 1 commit intojoomla:6.1-devfrom
Closed
Revert (#46438) [6.1] Fix TinyMCE editor not respecting width and height set#47325brianteeman wants to merge 1 commit intojoomla:6.1-devfrom
brianteeman wants to merge 1 commit intojoomla:6.1-devfrom
Conversation
…ings (joomla#46438)" This reverts commit 7996a3f.
joomla-cms-bot
added
Language Change
5 tasks
Member
Contributor
Author
|
they are not solutions they are band aids |
Member
|
I don't see them as bandaid, they fix the width problem, only band aid which will be remove is the check for '750px' -> '100%' thats wrong and should be solved with the pr #47326 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 7996a3f.
Pull Request resolves #47292 .
Summary of Changes
Reverts the changes in this PR that breaks the display of all editors in mail templates and tinymce wherever it is used on updates.
Instead of creating more and more band aid patches to address the serious regressions caused by that PR we should revert it now with this PR and then spend the time to fix it once correctly. It was not addressing a serious issue and it had ben present for a long time so there is no urgency to have a broken fix
Testing Instructions
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for guide.joomla.org:
No documentation changes for guide.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed